Repository navigation
docs: the Console lists the mods' commands, and why Give item can find the mod not loaded - #34
Merged
Merged
Conversation
Started while the servers and the game already ran, Waypoint's Give item answered "no running game has it loaded" for the Waypoint Tools mod, though the game's Gateway had it loaded. The Console asks the Gateway for its commands when Waypoint starts. That short-lived Gateway loads the mods too, for their commands, and the mod (up to 1.0.2) wrote data/waypoint-tools/loaded.json on every load: the file then named the asked process, which had ended, and Waypoint reads that as left by a Gateway that stopped. The mod is where this belongs, and its 1.0.3 leaves the file to the Gateway that runs the game. For the versions installed now, AskGateway keeps what the file said before its question and puts it back when the asked process wrote itself over a Gateway that still runs (WaypointToolsMod.KeepLoaded). With 1.0.3 the file does not change and nothing is put back. docs/launcher.md also said the mods' commands are not in the Console's list; they are, which is why the asked Gateway loads the mods. Checked in the running app on a 0.5.1-beta release folder with the 3.29.3d client and the released mod 1.0.2, Waypoint started while the character was in game: before, the refusal above; after, "Added Iron Ring" and the file naming the game's Gateway again. One unit test.
Takes the guard of the commit before out again: Waypoint no longer puts the Waypoint Tools mod's loaded.json back after asking a Gateway a question. That file is the mod's and Waypoint only reads it; the fault was the mod's, which wrote it from a Gateway that was only asked a question, and the mod's 1.0.3 fixes it there. The guard also had two holes: two questions asked at once left the file wrong, and it wrote through the temporary file name the mod uses. What stays is docs/launcher.md: - The Console's list holds the commands of the mods that are turned on: the Gateway that is asked loads the mods. It said they are not listed. - Why Give item can find the mod "not loaded" with the mod up to 1.0.2, and what clears it. Against main the branch now changes docs/launcher.md only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
docs/launcher.mdonly. Againstmainno code changes.commandsloads the mods that are turned on, which is how/item_giveand the othergm-commandscommands come to be listed.data/waypoint-tools/loaded.json, over the Gateway that runs the game, and ends. A Waypoint started while the game runs then finds the mod "not loaded" until the game's Gateway loads it again (the game started again, or the mod reloaded). The doc now says so, and that the file is the mod's: Waypoint only reads it.The fix is in the mod, LocalExile/LocalExile-Mods#39 (waypoint-tools 1.0.3), which leaves the file to the Gateway that runs the game. The doc names that version; if the mod change lands under another number, the line needs the same one.
Two commits, one net change
The first commit put a guard into Waypoint (
AskGatewaykeptloaded.jsonand put it back after its question, as #31 did); the second takes it out again and keeps the docs. It came out because the file belongs to the mod and the fault was the mod's, and because the guard had two holes: two questions asked at once left the file wrong, and it wrote through the temporary file name the mod uses. Squashing leaves the docs change alone.Checks
src/andtests/are identical tomain(git diff main --stat:docs/launcher.md, 7 insertions, 2 deletions), so nothing was built or run again for the second commit.GameServer.Gateway commandslisteditem_giveandcluster_jewel(both fromgm-commands) and rewroteloaded.jsonwith its own process; Give item then answered "no running game has it loaded" with the mod 1.0.2, and "Added Iron Ring" with the mod of fix(waypoint-tools): leave loaded.json to the Gateway that runs the game LocalExile-Mods#39.