Repository navigation
feat: make cluster jewels in the item crafter - #35
Merged
Merged
Conversation
Reported: a cluster jewel made with the crafter is created, but adds no
passive when socketed, while one from /cluster_jewel works.
A cluster jewel is its enchantments, which no implicit list or pool
names, so the crafter had nothing to put on the item. LocalExile's
crafter catalog now lists them (its Agents/docs/dev/item-crafter.md,
"Cluster jewels"), and this is Waypoint following it:
- Choosing a cluster jewel base puts its enchantments on the item:
"Adds N Passive Skills", which also holds the theme (what the small
passives grant), and its jewel sockets. They are sent to /item_give in
the enchant list.
- The theme is a list of the size's themes by name: the game's own value
is a number, which it words itself, so Waypoint words it from the
theme's stats ("Added Small Passive Skills grant: 12% increased Fire
Damage"). The passive count has a slider with the base's range, and the
socket enchantment a list of its socket counts.
- The theme decides the jewel's affixes: Prefixes and Suffixes list that
theme's notables with the modifiers every theme has.
- An enchantment's card says "Enchantment", the preview lists
enchantments first, and Add modifiers has a kind "Enchantments" on a
base that has some, to put one back.
- An imported cluster jewel takes its passive count, socket count and
theme from its enchantment lines, and its notables are found among
that theme's affixes.
Against a Gateway that does not list any of this, nothing changes.
3 of 8 tasks
Other_extraction_failures_keep_their_own_error asked for exactly two 3.29.3c executables. ClientLocator keeps every build a LocalExile's list named for the whole run, and a test in ClientUpdateTests names a made-up 3.29.3c hash, so the count was three whenever that test ran first: the two classes alone failed six runs of six. The test now checks Waypoint's own rows, which come first, by their hashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A player reported: a cluster jewel made with the item crafter is created, but it adds no passive when socketed, while one from
/cluster_jewelworks.A cluster jewel is its enchantments, which no implicit list or pool names, so the crafter had nothing to put on the item. LocalExile's crafter catalog now lists them (LocalExile/LocalExile#948, its
Agents/docs/dev/item-crafter.md, "Cluster jewels"), and this is Waypoint following it./item_givein the enchant list.docs/launcher.mdis updated, and four interface texts are new, with Russian and Simplified Chinese (not reviewed by a native speaker).Needs LocalExile/LocalExile#948
Against a Gateway that does not list any of this, nothing changes: a cluster jewel has no enchantments in the crafter. A server with that pull request still gives such a jewel a theme, a passive count and its sockets when it is given, so the report itself is fixed by the server change alone; this adds the choice.
Checks
dotnet build Waypoint.slnxandWaypoint.Linux.slnx: 0 warningsdotnet test Waypoint.slnx: 465 passed (one new, inCrafterCatalogTests)tests/Launcher.Checks: 208 passedtools/missing-translations.py: cleanmain4d8b8f1(which changeddocs/launcher.mdnearby; both edits are in the merged text)/cluster_jewelmakes from the same inputs.Not checked: the import window in the running app (a unit test covers it), the adapter's
tests/*.Tests.ps1(nothing underscripts/changed), Linux. Give item was run with the Waypoint Tools mod 1.0.2, whoseloaded.jsonhad to be put right by hand because Waypoint was started while the game ran (fixed in the mod since, LocalExile/LocalExile-Mods#39).Also here: a test that failed by run order
Second commit,
a87128d, tests only.ClientExtractionFailureTests.Other_extraction_failures_keep_their_own_errorasked for exactly two 3.29.3c executables.ClientLocatorkeeps every build a LocalExile's list named for the whole test run, and a test inClientUpdateTestsnames a made-up 3.29.3c hash, so the count was three whenever that test ran first. It failed this pull request's firstbuildrun andmain's own; the two classes run alone failed six runs of six.The test now checks Waypoint's own rows by their hashes (they come first). Nothing under
src/changed. After the change the two classes passed six runs of six and the whole suite three of three (465 each).