Skip to content

fix: name the program on a server port, and let mod changes past it - #36

Merged
evrydayjunglist merged 1 commit into
mainfrom
fix/port-holder-name
Nov 14, 2026
Merged

evrydayjunglist merged 1 commit into
mainfrom
fix/port-holder-name

Conversation

@evrydayjunglist

Copy link
Copy Markdown
Collaborator

What this changes

A player reported that ticking any mod failed with:

Port 8080 is occupied by another process (PID 29304); Patch is not owned by this checkout.

The servers were stopped. Their own port check found nothing because it filtered by process name. The program on 8080 turned out to be Steam's helper. Waypoint refused every mod change because any process it doesn't own on a server port counted as a conflict, even one that holds none of the mod files.

  • The message names the program: "Port 8080 is used by steamwebhelper.exe (PID 29304). Patch needs this port." When Waypoint cannot name it: "Port 8080 is used by another program (PID …)." Both have Russian and Simplified Chinese text (not reviewed by a native speaker); the old message is removed from the catalogs.
  • A program that is no LocalExile server no longer blocks file changes. The snapshot lists such a conflict in a new PortsInUse field. RuntimeSnapshot.EditConflicts (all conflicts but those) now gates the Mods section, Install, Update, the Use check box and Accounts, on Windows and Linux. The adapter applies the same rule in the mod, content (modules, leagues) and account guards.
  • Starts are unchanged. Such a program still blocks Start and Play (SafeToLaunch and the adapter's start checks still use every conflict), since Patch cannot bind its port. Another LocalExile's server or watcher on the port, or a holder Waypoint cannot name, still blocks everything.
  • Test-ServerProcess is the existing "foreign server or watcher" rule moved into a function, so both checks share it. Get-PortConflict builds the message.

docs/launcher.md (Mods) and docs/runtime-contract.md (ownership) are updated.

Checks

  • dotnet build Waypoint.slnx and Waypoint.Linux.slnx: 0 warnings
  • dotnet test Waypoint.slnx: 465 passed
  • tests/Launcher.Checks: 212 passed (new: EditConflicts, and both messages translated in every language)
  • Adapter suites: Bridge 47 (new: Steam's helper, another checkout's server, a release's server, an unknown holder), Accounts 23 (new: a port holder alone passes, with another conflict it blocks), Mods 13, ModControl 20, ModTransport 9, Source 62, Capture 19, SetupStop 6, ModBrowser 34, ContentBridge 40
  • tests/AccountData.Tests.py, tests/Capture.Tests.py, tools/missing-translations.py: clean
  • Live, on a real source checkout with Python's http.server listening on 127.0.0.1:8080:
    • Inspect reported "Port 8080 is used by python.exe (PID 45644). Patch needs this port." in both Conflicts and PortsInUse, and no account block.
    • The branch build (scratch WAYPOINT_HOME) ticked and unticked a mod on My Mods; mod-state.txt changed and was restored.

Not checked: the Play refusal in the running app (the click showed nothing and wrote nothing to the log; the button is most likely disabled; I did not push further, as a real start would run live.ps1 on that checkout), a release install, Linux at runtime.

🤖 Generated with Claude Code

A player could not tick a mod: Steam's helper was listening on 8080, the
Patch server's port, and Waypoint refused every mod change with "Port 8080
is occupied by another process (PID 29304); Patch is not owned by this
checkout." The servers were stopped, the message did not say which program
it was, and the program held none of the mod files.

- A port conflict now names the program holding the port: "Port 8080 is
  used by steamwebhelper.exe (PID 29304). Patch needs this port."
  (translated in Russian and Simplified Chinese).
- The snapshot lists such a conflict in PortsInUse when the holder is no
  LocalExile server or watcher. It still blocks a start, but no longer a
  change of mods, modules, leagues or accounts (EditConflicts in the app,
  the same rule in the adapter). Another LocalExile's server on the port,
  or a holder Waypoint cannot name, still blocks everything.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@evrydayjunglist
evrydayjunglist merged commit de3d0e7 into main Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant