chore: adopt oxfmt for root packages - #330
Open
hyoban wants to merge 1 commit into
Open
Conversation
Model: gpt-5
hyoban
marked this pull request as ready for review
September 3, 2026 06:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #118
Problem / pressure
Root-owned packages use Prettier through duplicated root and Electron configuration. The split setup can drift, and checking the full root-owned formatter corpus is substantially slower than Oxfmt.
Summary
.oxfmtrc.jsonwith shared defaults, explicit ACP submodule ignores, and an Electron override that preserves its semicolon and trailing-comma style.@electron-toolkit/eslint-config-prettierintegration and direct Prettier dependency unchanged so ESLint behavior remains outside this migration.The full-project benchmark recorded in #118 covered 3,094 root-owned files: Oxfmt averaged 1.247 seconds and Prettier averaged 17.786 seconds, a 14.26× speedup on the tested Apple M4 Pro checkout.
Before / after
.oxfmtrc.json; ACP submodules remain independently formatted.Test plan
pnpm install --frozen-lockfile --ignore-scriptspnpm formatpnpm format:checkpnpm checkapps/electron/eslint.config.mjsand its Prettier compatibility dependency remain unchanged.Context handoff
Instructions for reviewing agents
.oxfmtrc.json, workspace format scripts, and package boundaries to ensure root-owned packages share Oxfmt without traversing ACP submodules.Authoring context