feat(components): send role instructions as shortcuts - #339
Draft
lawvs wants to merge 1 commit into
Draft
Conversation
Contributor
|
I think this would make the concept of "role" complex and difficult to understand. I'd prefer to simply add a new "lody shortcut" for this. We might need to have a discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #338
Problem / pressure
Agent Role prompts can serve as reusable instructions, but the existing picker only applies the complete Role configuration. Sending just the prompt required manual copying and could disturb an in-progress composer draft or its attachments.
Summary
Before / after
Test plan
pnpm formatpnpm --filter @lody/components typecheckNODE_NO_WARNINGS=1 FORCE_COLOR=0 pnpm --filter @lody/components test --maxWorkers=1— 420 files and 3,023 tests passed.NODE_NO_WARNINGS=1 FORCE_COLOR=0 pnpm --filter @lody/components exec vitest run tests/agent-role-detail-pane.test.tsx tests/composer-agent-role-panel.test.tsx tests/mobile-run-config-role-row.test.tsx tests/session-chat-input-submission.test.tsx tests/agent-role-row.test.tsx --maxWorkers=1— 5 files and 40 tests passed after rebasing ontoorigin/main.pnpm lint:i18npnpm check:code-collab-importspnpm check:platform-boundariespnpm check:public-boundarygit diff --check origin/main...HEADpnpm checkreached passing workspace typechecks and lint with zero errors, but its default concurrent test stage was terminated by the local resource limit; the affected components suite was then rerun serially as recorded above.Context handoff
Instructions for reviewing agents
session-chat-interface.tsx, draft-preservation contract insession-chat-input-area.tsx, and the split Apply/Send behavior in the desktop and mobile Role surfaces.Authoring context