Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/cli/src/lib/message-handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3810,7 +3810,12 @@ export class MessageHandler {
this.getMachineFlockDocIdForMachine()
);
return readMachineFlockRowsFromFlock(handle.flock, {
families: ['archiveSessionCommand', 'deleteSessionCommand', 'deleteLocalProjectCommand'],
families: [
'archiveSessionCommand',
'deleteSessionCommand',
'deleteLocalProjectCommand',
'localProject',
],
});
}

Expand Down Expand Up @@ -3968,9 +3973,10 @@ export class MessageHandler {
this.logger.debug(`[${sessionId}] Preview tunnel closed for archive`);

const sessionRoomId = getSessionRoomId(sessionId);
const [sessionMetaDoc, archiveMachineMetaDoc] = await Promise.all([
const [sessionMetaDoc, archiveMachineMetaDoc, archiveMachineFlockRows] = await Promise.all([
this.workspaceDocument.repo.getDocMeta(sessionRoomId),
this.workspaceDocument.repo.getDocMeta(getMachineRoomId(this.machineId)),
this.tryReadMachineFlockCommandRows(),
]);
const sessionMeta = sessionMetaDoc?.meta as SessionMeta | undefined;
const archiveMachineMeta = archiveMachineMetaDoc?.meta as MachineLegacyMetaFields | undefined;
Expand All @@ -3986,6 +3992,7 @@ export class MessageHandler {
const cleanupTarget = this.resolveWorktreeCleanupTarget({
sessionMeta,
machineMeta: archiveMachineMeta,
machineFlockRows: archiveMachineFlockRows,
});
if (cleanupTarget) {
const worktreeManager = getWorktreeManager(this.buildWorktreeManagerConfig(cleanupTarget));
Expand Down
57 changes: 57 additions & 0 deletions apps/cli/tests/message-handler-terminal-cleanup.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,63 @@ function createHarness(options?: {
}

describe('MessageHandler terminal cleanup', () => {
it('cleans a local worktree when its project metadata exists only in the machine Flock', async () => {
const localProjectId = 'local-project-archive' as LocalProjectId;
const testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'lody-archive-project-'));
const originalDataDir = process.env.LODY_DATA_DIR;
const originalLocksDir = process.env.LODY_LOCKS_DIR;
process.env.LODY_DATA_DIR = path.join(testDir, 'data');
process.env.LODY_LOCKS_DIR = path.join(testDir, 'locks');
const rootPath = createLocalRepo(testDir);
const sessionId = 'session-archive-worktree' as SessionId;
const sessionMeta = {
id: sessionId,
machineId: 'machine-1',
createdAt: '2026-01-01T00:00:00.000Z',
userId: 'user-1',
cliType: 'codex',
agentType: 'codex',
status: SessionStatusFactory.idle(),
project: { kind: 'local', localProjectId },
isWorktree: true,
} as SessionMeta;
const machineFlockRows = [
{
key: machineFlockKeys.localProject(localProjectId),
value: {
id: localProjectId,
name: 'Project',
rootPath,
createdAtMs: 1,
},
},
];
try {
const manager = getWorktreeManager({
repoId: deriveRepoIdFromLocalProjectPath(rootPath),
source: { kind: 'local-shared', originalRootPath: rootPath },
logger: createSilentLogger(),
});
const worktree = await manager.createWorktree(sessionId);
const { handler, sessionManager } = createHarness({
sessionId,
sessionMetas: [sessionMeta],
machineFlockRows,
});

await handler.archiveSessionResources(sessionId);

expect(fs.existsSync(worktree.hostPath)).toBe(false);
expect(sessionManager.archiveSession).toHaveBeenCalledWith(sessionId);
} finally {
if (originalDataDir === undefined) delete process.env.LODY_DATA_DIR;
else process.env.LODY_DATA_DIR = originalDataDir;
if (originalLocksDir === undefined) delete process.env.LODY_LOCKS_DIR;
else process.env.LODY_LOCKS_DIR = originalLocksDir;
fs.rmSync(testDir, { recursive: true, force: true });
}
});

it('closes session terminals when archiving resources even without an active session', async () => {
const { handler, sessionId, closeSessionTerminals, sessionManager } = createHarness();

Expand Down