fix(components): render TeX bracket delimiters - #396
Conversation
Model: GPT-5
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e8b89cc8f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (cursor === lineStart) { | ||
| const fence = markdownFenceAt(value, lineStart); | ||
| if (fence) { | ||
| opening = null; | ||
| cursor = fencedCodeEnd(value, lineStart, fence); |
There was a problem hiding this comment.
Handle fenced blocks inside Markdown containers before rewriting delimiters. For example, in > ```tex\n> \(literal\)\n> ````, each line starts with >, so markdownFenceAtnever recognizes the fence and the code payload is changed to; list-nested fences fail similarly. Because MarkdownRenderer` also renders file previews, task bodies, and skill content, this visibly corrupts displayed and copied code rather than merely changing math rendering.
Useful? React with 👍 / 👎.
Model: GPT-5
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bfd558033
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (cursor === lineStart) { | ||
| const fence = markdownFenceAt(value, lineStart); | ||
| if (fence) { | ||
| opening = null; | ||
| cursor = fencedCodeEnd(value, lineStart, fence); |
There was a problem hiding this comment.
When Markdown uses a standard four-space-indented code block, such as \(literal\), markdownFenceAt returns null because there is no fence, and the subsequent scan rewrites the displayed and copied source to $$literal$$. Fresh evidence beyond the earlier nested-fence report is this non-fenced CommonMark code form; the normalizer needs to skip indented code blocks as well as fenced blocks and code spans.
Useful? React with 👍 / 👎.
| if (isOpening) { | ||
| opening = { kind, index: delimiterIndex }; | ||
| } else if (opening?.kind === kind) { | ||
| replacements.push(opening.index, delimiterIndex); | ||
| opening = null; |
There was a problem hiding this comment.
When a link or image destination contains Markdown-escaped balanced parentheses, for example [open](src/report\(final\).md), this scan rewrites the destination to src/report$$final$$.md before Streamdown parses it. The agent-file link remains syntactically file-like, so clicking it passes the altered href to the open-file path and targets a nonexistent filename; exclude Markdown destinations from delimiter normalization.
AGENTS.md reference: packages/components/src/lib/AGENTS.md:L31-L40
Useful? React with 👍 / 👎.
Model: GPT-5
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c1c801487
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| cursor += 1; | ||
| if (column >= 4) return lineEndAfter(value, lineStart); |
There was a problem hiding this comment.
When a normal list continuation uses four root-relative spaces, such as - explanation\n \(x\), CommonMark removes the list item's two-space content indent and treats the remainder as paragraph indentation, not an indented code block. This absolute-column check nevertheless skips the entire line, so TeX delimiters in commonly formatted list content remain literal; account for the active container indentation before applying the four-column code rule.
Useful? React with 👍 / 👎.
1 participant
Problem / pressure
Codex and other agents emit TeX parenthesis and bracket math delimiters, while Streamdown renders dollar-delimited math. Those formulas currently appear as literal text.
Summary
Before / after
Test plan
NODE_ENV=test pnpm exec vitest run tests/markdown-math-delimiters.test.ts tests/markdown-streaming-reparse.test.ts --maxWorkers=2(38 passed)pnpm --filter @lody/components typecheckpnpm check:quickcomponents passed through lint, i18n, Code Collab, and platform checks; the sandbox-blocked public-boundary step was rerun separatelypnpm check:public-boundary