fix: enable Codex Astra Max and Ultra reasoning - #406
Merged
lodystage[bot] merged 2 commits intoSep 5, 2026
Conversation
Align extended reasoning with the ACP model catalog, including Max-only support for Luna. Model: gpt-6-astra
Match the submodule's ^0.153.4 requirement so frozen installs can run in both CI jobs. The resolved package remains 0.153.4. Model: gpt-6-astra
lodystage
Bot
deleted the
feat/codex-provider-gpt-56-max-ultra-gpt-6-astra
branch
September 5, 2026 03:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / pressure
The built-in Codex UI removed Max and Ultra from
gpt-6-astrabecause its reasoning normalization recognized only three GPT-5.6 model IDs. It also offered Ultra for Luna, although the current ACP model catalog advertises only Max for that model.Summary
Use an exact per-model extended-effort map: Astra, Sol, and Terra support Max/Ultra; Luna supports Max. Preserve upstream labels and descriptions, fill missing supported options in cached selectors, and remove unsupported efforts when the selected model changes. Older and unknown models keep their existing restrictions.
Test plan
acp-selector-options,acp-session-config-selection, andsession-config-selection-oscillation.pnpm typecheck) andpnpm --filter @lody/components typecheckpassed.pnpm checkwas stopped after repeated failures in untouched UI test suites reportingact is not a function. Reproduced independently withpnpm --filter @lody/components test tests/agent-config-dialog.test.tsx --bail=1: it fails at the test renderer'sact()call before rendering. The full suite and later checks therefore did not complete.ERR_PNPM_OUTDATED_LOCKFILE. Align the root lockfile specifier with the Codex submodule's^0.153.4requirement; the resolved version stays0.153.4.pnpm install --frozen-lockfile,pnpm format:check, and all 53 relevant tests passed locally after this one-line fix.