Skip to content

feat: display Claude Fable weekly quota - #407

Merged
lodystage[bot] merged 2 commits into
mainfrom
feat/claude-fable-weekly-quota
Sep 5, 2026
Merged

feat: display Claude Fable weekly quota#407
lodystage[bot] merged 2 commits into
mainfrom
feat/claude-fable-weekly-quota

Conversation

@zxch3n

@zxch3n zxch3n commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Claude's Fable weekly sub-cap was dropped because the adapter only read the shared 5-hour and 7-day fields, and Lody rendered window names from duration alone. Preserve the additive Core window label through ACP parsing and show it beside the duration in the usage popover, Provider row, and machine quota panel. Shared and Fable weekly constraints remain separate even when their duration, utilization, or reset time matches.

Pins the merged companion implementations: Core #3 and Claude adapter #25. Core is pinned to 7bc6332d3f007876895b4a3a827be0060f4d5318 and Claude to 414718e5238a7ed5da0ff23bec31bff4450ffa5f, the confirmed merge commits on their main branches. Both builds and all 8 Claude usage tests passed again with these revisions. Older unlabeled windows remain compatible; snapshots replace the window list, so removed scoped quotas do not linger. Also repairs the existing Codex lockfile specifier mismatch without changing its resolved version, allowing frozen installs.

Validation: 34 targeted tests passed across adapter parsing, ACP reception, display, and legacy keying/migration. Core and Claude builds, Core typecheck, Claude lint/format checks, repository-wide typecheck and lint, i18n, public-boundary checks, and formatting of changed files passed. Browser checks passed for the real usage-popover component at 1024px and 390px and the compact Provider row. Full NODE_ENV=test pnpm check is still running its test phase. OAuth fixtures are synthetic; no live account credentials were used.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 09e9fa9296

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +191 to +195
label={formatAgentRateLimitWindowLabel(
window,
formatRateLimitWindowShortLabel(window.windowDurationSeconds),
t
)}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve quota labels in the narrow provider layout

When the provider card is below the @sm container breakpoint, this changed block is hidden by hidden ... @sm:flex, while the @sm:hidden fallback later in the same component still uses only formatRateLimitWindowShortLabel. Consequently, Claude's shared weekly and Fable weekly meters both appear as 7d on mobile and narrow settings panels, making the new quota indistinguishable; apply formatAgentRateLimitWindowLabel in that fallback as well.

Useful? React with 👍 / 👎.

@lodystage
lodystage Bot merged commit cfd73e8 into main Sep 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants