fix: align the workspace Node runtime floor - #72
Conversation
Keep root runtime declarations and contributor guidance aligned with the Node-API 10 floor already enforced by the CLI SQLite guard. Model: GPT-5
|
This PR predates the contribution-intake policy introduced in #91. I opened #116 with the reproduction and proposed scope, and I am waiting for explicit maintainer agreement before updating the branch or converting the body to the current template. The prepared follow-up also resolves the post-#60 documentation gap: Prepared validation: CLI runtime tests 12/12 passed, turn-diff-store tests 31/31 passed, both typechecks passed, type-aware lint and code formatting passed, docs generation passed, repository boundary checks passed, and |
Related issue
Closes #116
Problem / pressure
The SQLite binding requires Node-API 10. The workspace admitted Node 22.0-22.13 and the simple
>=22.14.0range also admits Node 23.0-23.5, although Node-API 10 starts at 22.14.0 and 23.6.0. The pinned pnpm 10.20 additionally does not enforcedevEngines.runtime.onFail: error, so unsupported installs could continue after warnings; newer global pnpm versions could also bypass the legacypackageManagerpin.Summary
>=22.14.0 <23 || >=23.6.0.process.versions.napiis below 10.engines.pnpm, while retaining the existing Corepack pin.PR #60 has merged. A reviewed follow-up that aligns its quickstart wording with the exact Node 22.14-22.x or 23.6+ boundary remains local until issue #116 receives maintainer agreement.
Before / after
Test plan
corepack pnpm --dir apps/cli exec vitest run tests/sqlite-runtime-support.test.ts tests/native-sqlite-install-free.test.ts(11 passed)corepack pnpm --dir apps/cli typecheckcorepack pnpm --dir packages/turn-diff-store test(31 passed)corepack pnpm --dir packages/turn-diff-store typecheckcorepack pnpm exec oxlint --type-aware apps/cli/src/utils/sqlite-runtime-support.ts apps/cli/tests/sqlite-runtime-support.test.ts scripts/check-node-runtime.mjs(0 warnings/errors)corepack pnpm exec prettier --checkon all changed filesengines.pnpm;corepack pnpmresolves the pinned 10.20.0corepack pnpm lint:i18ncorepack pnpm check:code-collab-importscorepack pnpm check:platform-boundariescorepack pnpm check:public-boundarygit diff --check origin/main...HEADContext handoff
Instructions for reviewing agents
devEngines.runtime.onFail: error.Authoring context