fix(electron): detect available session path launchers - #73
Merged
Conversation
Model: gpt-5.4
4 tasks
Contributor
|
This is a good feature! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fix #138
Problem / pressure
The Session header advertised every platform-compatible path launcher, even when the corresponding editor or URL protocol was not installed on the local machine. Selecting one then failed only after the user tried to launch it.
Summary
PATH, platform executable rules, known absolute fallbacks, macOS application lookup, and registered URL protocols.Before / after
Test plan
node --disable-warning=MODULE_TYPELESS_PACKAGE_JSON --experimental-strip-types --test src/main/services/local-path-launcher-core.test.mjs— 5 tests passed.zoddependency.Context handoff
Instructions for reviewing agents
app-ipc.ts, cross-platform command discovery inlocal-path-launcher-service.ts, and filtering lifecycle insession-chat-interface.tsx.Authoring context