fix: retain undelivered marker on new messages - #88
Open
Pleasurecruise wants to merge 1 commit into
Open
Conversation
Pleasurecruise
force-pushed
the
fix/late-msg
branch
from
August 28, 2026 16:43
a6960b1 to
81ae23c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fix #47
Problem / pressure
PR #74 made
lastMissingHistoryUserMsgIda permanent negative acknowledgement for an undelivered turn, but missed the ordinary new-message path:status: pending.latestUserMsgIdat B but also clears A's marker.This can execute a message the UI already presented as not delivered.
Summary
mainand resolve the contributor-invariant conflict.Before / after
pendingA dispatchable again.latestUserMsgId; A remains excluded and B dispatches normally.Test plan
packages/components/node_modules/.bin/vitest run tests/use-session-actions.test.ts tests/resend-undelivered-dialog.test.tsx tests/undelivered-user-turn.test.ts— 34 tests passed after rebasing.apps/cli/node_modules/.bin/vitest run src/session/session-dispatch-logic.test.ts tests/session-dispatch-watcher.test.ts— 50 tests passed after rebasing.tsgo --noEmitpassed before the rebase.git diff --checkpassed after conflict resolution.Context handoff
Instructions for reviewing agents
use-session-actions.tspreserves an existing marker while movinglatestUserMsgIdto B.Authoring context
mainto resolve conflicts.