chore(electron): upgrade Vite to v8 - #89
Open
sheepbox8646 wants to merge 1 commit into
Open
Conversation
Upgrade the Electron build chain to Vite 8, the compatible React plugin, and electron-vite 6 beta. Migrate renderer bundling to Rolldown-native options while preserving the guarded Mermaid chunk and keeping shared Vite helpers compatible across workspace majors. Model: gpt-5
4 tasks
Contributor
|
Might the electron-vite 6 beta carry a risk of instability? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #154
The Issue was created after this PR to correct an authoring-process oversight and is awaiting explicit maintainer agreement.
Problem / pressure
The Electron application was still pinned to Vite 7 while the repository already carries and validates Vite 8 elsewhere. The Electron-specific build chain and Rollup-era configuration needed to move together so the desktop production build could use Vite 8 without peer mismatches or losing its guarded Mermaid chunk boundary.
Summary
@vitejs/plugin-react6, and the Vite 8-compatibleelectron-vite6 beta.rolldownOptionsandcodeSplitting.groups.vite-plugin-wasm@3.5.0in pnpm peer rules and refresh the lockfile.Before / after
electron-vite5 and React plugin 5.electron-vite6 beta and React plugin 6.build.rollupOptions,manualChunks, andonlyExplicitManualChunks.build.rolldownOptions.output.codeSplitting.groups;mermaid-depsremains isolated.Test plan
corepack pnpm --dir apps/electron build:app— passed; built main, preload, and renderer with Vite 8.1.5, including WASM assets and the isolatedmermaid-depschunk.corepack pnpm --dir apps/electron test— passed, 43 tests.corepack pnpm --filter @lody/components typecheck— passed.corepack pnpm --filter @lody/components exec vitest run tests/vite-renderer-bundle-aliases.test.ts— passed, 2 tests.corepack pnpm check:public-boundaryand Prettier checks for changed files — passed.corepack pnpm check:quick— attempted but blocked by pre-existing errors in untouched files and the independently managed Kimi submodule.Context handoff
Instructions for reviewing agents
electron.vite.config.tsRolldown chunk configuration, especially preserved Mermaid and WASM behavior.electron-vite@6.0.0-beta.1is acceptable before stable Vite 8 support is released.Authoring context