fix: add read-only Lody history extension [risk:medium] - #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk: 🟡 medium | Confidence: high — adds a private request surface and history projection path; covered by transport, writer-conflict, full unit, typecheck, and build validation
Summary
agentCapabilities._meta.lody.readSessionHistoryversion 1 with method_lody/session/history/readthread/readwithincludeTurns: truesession/updatenotifications using ephemeral stateloadSessionand interactive session ownership unchangedWhy
Lody conversation import currently reaches Codex through
loadSession, which resumes the thread before reading it. Codex rejects that resume when another process already owns the thread writer. The new Lody-only request provides a read-only path that never callsthread/resumeor installs an active adapter session.Verification
npm run typechecknpm test— 463 passed, 29 skippednpm run buildReview focus
Please verify that the new path remains read-only: one
thread/read, standard history notifications, and no active session-map installation.Affected package:
acp-extension-codexRelated: https://github.com/loro-dev/lody/issues/3440
The Lody caller migration will be handled separately after this extension lands.