fix: cancel non-turn context compaction - #30
Open
UniversePeak wants to merge 1 commit into
Open
Conversation
Model: gpt-5.6-luna
UniversePeak
force-pushed
the
fix/cancel-compaction
branch
from
September 5, 2026 07:26
c019cbe to
0e2a6d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Stopping
/compactwhile it is waiting forthread/compactedleaves the ACP prompt active. Subsequent prompts are rejected as already active.Change
Track the non-turn compaction lifecycle on the owning prompt and cancel that prompt directly when ACP cancellation arrives.
Tests
corepack pnpm --filter acp-extension-core buildcorepack pnpm --filter acp-extension-codex typecheckcorepack pnpm --filter acp-extension-codex exec vitest run src/__tests__/CodexACPAgent/CodexAcpClient.test.ts -t "cancels a compact slash command without waiting for compaction completion" --no-file-parallelismThe full Codex ACP test file passed 100 tests; two unrelated existing Windows path-normalization tests failed.
Model: gpt-5.6-luna