Repository navigation
Conversation
Author
|
One CI note: Dependency Review reports that it isn't available for this repository and asks for Dependency graph to be enabled. The tests, quality, build and CodeQL checks are green. Could you check that setting when you have a moment? Thanks for taking a look. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
I reproduced this with the documented Fastify setup: routes registered on the parent instance never reached the logging hooks. The plugin now shares the registering scope, so those routes and routes in child plugins are logged as expected.
The response hook also respects the skip decision, so skipped requests stay out of both completion logs and slow request warnings. The new integration tests use a real Fastify instance and cover both route scopes, skipping, custom error levels, slow requests, and silent request start logging.
Fastify is only added for development. Its injection helper is pinned within the supported range to keep the tests compatible with Jest on Node 18, 20, and 22.
Closes #32
How I tested it
The new tests reproduce the original failure and pass with the fix. All 945 tests pass on Linux with Node 22 using
npm test -- --runInBand, along withnpm run typecheck,npm run lint,npm run format:check, andnpm run build. The middleware's 11 tests also pass separately on Node 18, 20, and 22. I checked the test file with strict TypeScript settings as well.Checklist
feat: ...,fix(transport): ...,docs: ...). It becomes the squash commit and drives the release.npm run typecheck && npm run lint && npm testpass locally