Repository navigation
fix(config): validate and normalize log levels - #51
Merged
webcoderspeed merged 1 commit intoOct 23, 2026
Merged
Conversation
Disha-k-gowda
marked this pull request as ready for review
October 18, 2026 21:02
Contributor
|
Thanks, this reads well. Upper-case env levels work, unknown levels warn once per source, and Small note: |
|
🎉 This issue has been resolved in version 1.12.6. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes #29
This PR fixes log-level validation and normalization in Logixia.
Previously:
DEBUGwere not handled correctly.setLevel('nope')could unexpectedly change the effective logging threshold.Changes:
setLevel()calls without changing the current level.Invalid environment overrides now fall through to the next configured level. Maintainer feedback on this behavior is welcome.
How I tested it
npx jest src/core/__tests__/level-validation.test.ts --runInBand: 8/8 passednpx jest src/core/__tests__/custom-levels.test.ts --runInBand: 31/31 passednpm run typecheck: passednpm run lint: passedThe remaining failure is a pre-existing Windows
EPERMsymlink-permission error insrc/cli/__tests__/index.test.ts.Checklist
AI Assistance Disclosure
I used Claude Code to assist with understanding the codebase, drafting regression tests, proposing implementation changes, and reviewing diffs. I independently reviewed the generated changes, corrected issues found during review, and verified the behavior using local tests, typechecking, and linting. I take responsibility for the final contribution.