feat(TinyVec): add into_vec() & into_boxed_slice()#206
Merged
Lokathor merged 7 commits intoLokathor:mainfrom Mar 3, 2025
Merged
feat(TinyVec): add into_vec() & into_boxed_slice()#206Lokathor merged 7 commits intoLokathor:mainfrom
into_vec() & into_boxed_slice()#206Lokathor merged 7 commits intoLokathor:mainfrom
Conversation
Lokathor
reviewed
Feb 20, 2025
Owner
Lokathor
left a comment
There was a problem hiding this comment.
Looks good, just one little typo in the doc comments
src/tinyvec.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// Converts a `TinyVec<[T; N]>` into a `Box<T>`. |
Owner
There was a problem hiding this comment.
I think this should say Box<[T]>
Owner
|
oops, might want to pick smaller array sizes for the doctest example |
Contributor
Author
Now, |
Contributor
Author
|
When I changed the doc comment: I re-ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustfmt.toml: replace deprecated
fn_args_layoutwithfn_args_layoutsee also: Rename
fn_args_layoutconfig option rust-lang/rustfmt#4149benches/smallvec.rs: After running
cargo +nightly fmt, the format was automatically changed.src/tinyvec.rs:
impl<A: Array> Into<Vec<A::Item>> for TinyVec<A>into_vec()&into_boxed_slice()into_vec()
The specific implementation is in the
into()method ofimpl Into<Vec<A::Item>>.into_boxed_slice()
Converts a
TinyVec<[T; N]>into aBox<[T]>.TinyVec::Heap(Vec<T>), it takes theVec<T>and converts it intoa
Box<[T]>without heap reallocation.TinyVec::Inline(inner_data), it first converts theinner_datatoVec<T>, then into aBox<[T]>. Requiring only a single heapallocation.
Example
Closes #205