Skip to content

Auto-close test: stop two cases racing their own timers on a slow runner #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shakibbinkabir wants to merge 1 commit into from
Closed

Auto-close test: stop two cases racing their own timers on a slow runner #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tests/IslandAutoCloseTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,15 @@ enum IslandAutoCloseTests {
try await waitForCompact(edited, timeout: 1)

// Increasing the delay must also cancel the previous, shorter timer.
// The new delay is a full second: the sleep below only has to outlast
// the old 50 ms timer, and on a busy CI runner a 100 ms sleep can run
// long enough to meet a timer set a few hundred milliseconds out.
let extended = openedMachine(delay: 0.05)
extended.mouseLeft()
extended.homeToPetitDelay = 0.25
extended.homeToPetitDelay = 1
try await Task.sleep(for: .milliseconds(100))
precondition(extended.state == .home)
try await waitForCompact(extended, timeout: 1)
try await waitForCompact(extended, timeout: 3)

// Returning to the island cancels the countdown; leaving starts it again.
let hovered = openedMachine(delay: 0.05)
Expand All @@ -45,14 +48,15 @@ enum IslandAutoCloseTests {
try await waitForCompact(hoveredEdit, timeout: 1)

// Greeting timing is independent from the normal auto-close preference.
// A full second here too, for the same reason as above.
let greeting = IslandStateMachine()
greeting.greetAutoCollapseDelay = 0.15
greeting.greetAutoCollapseDelay = 1
greeting.launch()
greeting.greetComplete()
greeting.homeToPetitDelay = 0.01
try await Task.sleep(for: .milliseconds(50))
precondition(greeting.state == .coucou)
try await waitForCompact(greeting, timeout: 1)
try await waitForCompact(greeting, timeout: 3)

// An unanswered approval holds the island open even after a delay edit.
let heldOpen = openedMachine(delay: 0.05)
Expand Down
Loading