Repository navigation
Windows & Linux: the chat's picker offers the providers that are set up - #364
Closed
shakibbinkabir wants to merge 1 commit into
Closed
shakibbinkabir wants to merge 1 commit into
shakibbinkabir wants to merge 1 commit into
Conversation
The picker listed every cloud provider, with or without a key, next to the model servers, which only show once connected. It now treats them alike: a cloud provider shows once its key is in the credential store, a model server once it is connected, and the active provider always, so the picker never hides where the chat goes. With nothing set up, the active provider says its key is missing and links to Settings, as before. The store is only asked whether each key is there, when the picker is built and each time it opens, so a key added in Settings shows the next time. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Folded into #365, which has this as one of four separate commits you can take or leave on their own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proposal, separate from #363 so each can be decided on its own. This one changes behaviour, and it departs from the Mac, so say no if you want the two to stay alike.
What changes
The picker lists every cloud provider whether or not it has a key. Picking one without a key leads to "No API key — add it in Settings". Model servers already work differently: Ollama, LM Studio and a custom server only show once connected.
This treats cloud providers the same way: one shows once its key is in the credential store. The active provider always shows, so the picker never hides where the chat goes. With nothing set up, the active provider still says its key is missing and links to Settings, exactly as today.
Same machine, same keys: Anthropic, Google and OpenRouter have one, OpenAI does not. The chips keep their look and their order; only the one with nothing behind it is gone.
How
visibleProviders(settings, hasKey)incore/providers.tsis the whole rule and stays pure.Parity
On the Mac,
ModelPickerViewshows the cloud providers always. If you want this there too, it is the same filter withKeychainStore; I can add it, compiled and tested by CI only, since I have no Mac.Tests
npm test: 325 pass. The providers test is rewritten for the new rule, and the chat test that pinned four chips with no key now expects only the active one; one new test covers a key added between two openings.tsc --noEmitclean. No Rust change.🤖 Generated with Claude Code