Repository navigation
Auto-close tests: margins that hold on a slow CI runner - #376
Merged
Merged
Conversation
The macOS runner failed this test on main and on #372 while nothing it covers had changed. The two cases that raced a short timer against a short sleep now check long after the old timer and long before the new one, and every wait gets the 5 s default instead of 1 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LJm3SRL9k3gBPaVtfPhwcT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS runner failed
Test auto-close timingon main (637b576) and #372 with no related change. Widens the two racy cases and the wait timeouts, like #336 did for the hover tests.🤖 Generated with Claude Code
https://claude.ai/code/session_01LJm3SRL9k3gBPaVtfPhwcT
Generated by Claude Code