Repository navigation
Contributing: look for an open pull request before starting one - #440
Open
shakibbinkabir wants to merge 1 commit into
Open
shakibbinkabir wants to merge 1 commit into
shakibbinkabir wants to merge 1 commit into
Conversation
The same fix or feature is often open in several pull requests at once. The Windows source for the Spotify pill is in six of them today. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line added to
CONTRIBUTING.md, under "Pull requests":Why
There are 159 open pull requests, and the same work is in several of them at once. The case I compared closely is the Windows source for the Spotify pill, which is open six times:
media.rsmedia.rsmedia.rsThe last three were opened within a day of each other. They read the same Windows API and change the same lines of
pills.tsandspotify.rs, so at most one of them can merge as it is. #83 names #80 and #374 names #83; the two newest name none of the others. Each one costs you a review to find that out.The rule asks for a search before the work starts, and for the PR to say so when it knowingly overlaps another.
What it does not do
CONTRIBUTING.mdchanges. Of the open PRs that edit that file, none touches the "Pull requests" section.🤖 Generated with Claude Code