Skip to content

Contributing: look for an open pull request before starting one - #440

Open
shakibbinkabir wants to merge 1 commit into
Louis-CFM:mainfrom
shakibbinkabir:contributing-check-open-prs
Open

shakibbinkabir wants to merge 1 commit into
Louis-CFM:mainfrom
shakibbinkabir:contributing-check-open-prs

Conversation

@shakibbinkabir

Copy link
Copy Markdown
Contributor

One line added to CONTRIBUTING.md, under "Pull requests":

Before you start, search the open pull requests for the same fix or feature. If one is already pending, review it or build on it rather than opening a second one. If yours really differs, link the other one and say how.

Why

There are 159 open pull requests, and the same work is in several of them at once. The case I compared closely is the Windows source for the Spotify pill, which is open six times:

PR Opened How
#79 1 Oct in a bundle, media.rs
#80 1 Oct in a bundle, media.rs
#83 1 Oct its own views, media.rs
#374 8 Oct under #372's page, from the system media session (this one is mine)
#383 9 Oct under #372's page, from the system media session
#418 9 Oct under #372's page, from the system media session, with Apple Music and other players (#432 is stacked on it)

The last three were opened within a day of each other. They read the same Windows API and change the same lines of pills.ts and spotify.rs, so at most one of them can merge as it is. #83 names #80 and #374 names #83; the two newest name none of the others. Each one costs you a review to find that out.

The rule asks for a search before the work starts, and for the PR to say so when it knowingly overlaps another.

What it does not do

  • No PR template and no CI check. It is a sentence in the guide; nothing enforces it.
  • Nothing else in CONTRIBUTING.md changes. Of the open PRs that edit that file, none touches the "Pull requests" section.
  • No open PR or issue already proposes this. I looked before writing it.

🤖 Generated with Claude Code

The same fix or feature is often open in several pull requests at once.
The Windows source for the Spotify pill is in six of them today.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant