Repository navigation
Build the Docker image without emulation - #5
Merged
Merged
Conversation
The multi-arch image ran the whole build twice, the arm64 half under QEMU: the SvelteKit UI (about 4,000 Svelte files) and the Go compile in emulated Node and Go. The v0.2.2 image job ran past 55 minutes. Both build stages now run on the build machine's platform (BUILDPLATFORM): the UI is the same files for every architecture and Go cross-compiles with GOOS/GOARCH from TARGETPLATFORM. The final stage only copies files, so the QEMU setup step is gone. Without cache: amd64 72 s, arm64 82 s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow built the multi-arch image by running the whole Dockerfile once per platform, the arm64 half under QEMU: the SvelteKit UI (~4,000 Svelte files) and the Go compile ran in emulated Node and Go. The v0.2.2 image job went past 55 minutes (earlier versions took 6–12).
BUILDPLATFORM(the runner's own architecture). The UI output is identical for every platform; Go cross-compiles withGOOS/GOARCHfromTARGETOS/TARGETARCH.setup-qemu-actionstep is removed.docker buildx build --no-cache: linux/amd64 in 72 s, linux/arm64 in 82 s; the arm64 image's binary is AArch64 and the amd64 one runs (lowlex version).The PR CI does not build the image (that job runs only on tags), so the first real check is the next release tag.