Repository navigation
fix: one scrollbar, at the window edge - #8
Merged
Merged
Conversation
PageShell was both the scroll container and the centred max-width column, so its scrollbar sat beside the content; and the hidden labels and checkbox inputs in RecordList, absolutely positioned with no positioned ancestor, stretched the document into a second scrollbar that moved the whole shell. The shell's full-width content area now scrolls and contains them (workaround for codeatlasdev/ui#673).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The translations page (and any long page) had two scrollbars: one beside the content and one for the whole document.
PageShellis both the scroll container and the centred 1280 px column, so its scrollbar floats beside the content on wide screens.RecordCell) and checkbox inputs insideRecordListare absolutely positioned with no positioned ancestor, so they escape the clip and stretch the document, scrolling the sidebar too.The shell's full-width content area (
.ca-shell__content) now scrolls and contains them;PageShellstays the centred column without its own scroll. Workaround markedca-ui-workaround(#673), reported as codeatlasdev/ui#673.Testing: locally with 150 keys at 1600×900 and 375×812: a single scroll container, the document never scrolls, the sidebar and phone bottom bar stay put, pagination is reachable above the bottom bar; projects, tasks, languages, transfer, users and account pages unchanged.
svelte-checkis clean.