Repository navigation
feat: MCP server section in Settings - #114
Merged
Merged
Conversation
Settings gets an MCP server tab: turn the server on (sharing the open vault the first time), choose the shared vaults, see whether it runs and how many requests it served, copy the configuration for Claude Desktop, Claude Code and Cursor, and regenerate the access token, which disconnects every client. The backend adds mcp_status, save_mcp_settings and mcp_regenerate_token. A restart waits for the previous server to release the pipe or socket. The token stays in the OS credential store; the interface only sees the path of the lownotes-mcp program. Closes #103
FabioHAraujo
force-pushed
the
feat/mcp-settings
branch
from
October 29, 2026 20:59
05ce4ff to
6a63ecb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #113 (the
lownotes-mcpbridge): merge that first. Until then this diff also shows the bridge commits.Settings gets an MCP server tab, so turning the server on no longer means editing
settings.json.Interface
mcpServersJSON entry) and aclaude mcp add --scope usercommand for Claude Code, all pointing atlownotes-mcpnext to the app.appConfirm), stores a new token and restarts the server, which disconnects every client.en-US,pt-BRandes-ES.Backend
mcp_statusreturns whether the server runs, the request count, the bridge path and whether that path is temporary. It never returns the token.save_mcp_settings(enabled, vaultIds)keeps only vault ids that exist, saves, and starts or stops the server.mcp_regenerate_tokenreplaces the token in the OS credential store and restarts the server.on_workerbecomespub(crate)so the MCP commands run on the blocking pool like the others.Tests
tests/mcp-config.test.tscovers the client JSON and the shell quoting of the Claude Code command for Windows, macOS and a path with a quote.tests/e2e/mcp.pw.tsturns the server on and checks the saved arguments and the shared vault. It also checks the status, the snippets with a Windows path, unsharing the vault, and regenerating the token.Full AGENTS.md verification on Windows passes: install,
version:check,check,check:e2e,bun test, the Python script tests,cargo fmt,clippy -D warnings,cargo testandbun run build, plustest:e2e. I ran it again after mergingmain(Excalidraw).Not in this PR: the Allow changes switch in the issue belongs to the write tools (#105), which are out of scope for v0.5.0.
Closes #103