Skip to content

Add support for AllPower AP25Q128HHD flash chip - #3

Closed
LoyalLinjy wants to merge 2 commits into
masterfrom
Add_NorFlash_Chip
Closed

Add support for AllPower AP25Q128HHD flash chip#3
LoyalLinjy wants to merge 2 commits into
masterfrom
Add_NorFlash_Chip

Conversation

@LoyalLinjy

Copy link
Copy Markdown
Owner

Test

@github-actions

Copy link
Copy Markdown

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

@github-actions

Copy link
Copy Markdown

🤖 Kimi Code Review Report

中文审查报告

变更总结:
在 Blackbox 文档与 flash_m25p16.c 驱动中新增对 AllPower AP25Q128HD(128 Mbit / 16 MB)闪存芯片的支持。文档仅追加一行型号;驱动在 JEDEC 表末尾插入一条记录,JEDEC ID 为 0x852018,页大小 256 B,总容量 256 页(=64 KB),与数据手册一致。

问题与建议:

  1. 容量字段填写错误:驱动中 256 页仅 64 KB,而芯片实际为 16 MB(65536 页)。应改为 {0x852018, 65536, 256}
  2. 数据手册链接指向第三方 GitHub 镜像,建议换成厂商官网或可靠镜像,降低失效风险。
  3. 新增条目未按 JEDEC ID 升序排列,破坏查找表有序性,可能造成首次匹配失败或效率下降。
  4. 缺少测试记录或 CI 构建日志,无法验证芯片真实兼容性与擦写流程是否正常。
  5. 提交信息未说明是否已在硬件上验证读写、擦除、SFDP 等功能,建议补充验证步骤与结果。

代码评分: 2/5


English Review Report

Summary:
Adds support for AllPower AP25Q128HD (128 Mbit / 16 MB) flash to both the Blackbox documentation and the flash_m25p16.c driver. A single line is appended to the docs; the driver inserts a new JEDEC table entry with ID 0x852018, page size 256 B and 256 pages (64 KB), referencing a datasheet hosted on GitHub.

Issues & Suggestions:

  1. Incorrect capacity: 256 pages = 64 KB, but the chip is 16 MB (65 536 pages). Entry should be {0x852018, 65536, 256}.
  2. Datasheet URL points to a third-party GitHub mirror; prefer an official vendor link to reduce future breakage.
  3. Table is no longer sorted by JEDEC ID, which may break the first-match search logic or slow it down.
  4. No test evidence or CI logs provided; actual compatibility (read, write, erase, SFDP) is unverified.
  5. Commit message lacks hardware-validation details; please state which board/firmware config was tested and the results.

Rating: 2/5 stars


Generated by Kimi AI

@LoyalLinjy LoyalLinjy closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant