Перенос Вендоматов с Луны - #167
Open
CQuarian-dev wants to merge 2 commits into
Open
CQuarian-dev wants to merge 2 commits into
CQuarian-dev wants to merge 2 commits into
Conversation
Разобраться в щиткоде было больно, я не знаю ПОЧЕМУ UI берётся из загрузчика боеприпасов
github-actions
Bot
added
S: Untriaged
FTL
C#
UI
S: Needs Review
size/M
and removed
S: Untriaged
labels
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
Author
|
Так а в чём проблемы, если работает. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Разобраться в щиткоде было больно, я не знаю ПОЧЕМУ UI берётся из загрузчика боеприпасов
О пулл-реквесте
Перенос UI меню для загрузчика боеприпасов и торгоматов
Обоснование / Баланс
Никак не влияет, просто красивое изменение.
Технические детали
Замена старого UI на новый LuaVendingMachineWindow.xaml(.cs),
То есть были удалены VendingMachineItem и VendingMachineMenu (.xaml + .cs). то есть старое окно Monolith, его заменило новое, и всвязи с этим оно было полностью удалено из-за отсутствия его использования вообще после замены на Lua-стиль.
Как протестировать
Открыть любой торгомат или загрузчик боеприпасов
Медиа
Требования
Журнал изменений
🆑