Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the #166 evidence-chain issues #160, #170, #173, and #175 as benchmark-only commits. No production retrieval behavior changes.
#160 — Application corpora (8e2e838, 6fc9de5)
Adds three real-application corpora so every parsed language now has one library and one application:
badae6a5cc8325dcd5a145bea6f7b8ac692818a1b7952299941543d4507ac7931edb223acd684b3d(v2.13.1)94e7c8874e526b1e67b349d9ba30ddf81669119e(v0.17.0)Each manifest carries 15 authored Pix-style queries with four query forms and exact
file + symbolgold.vp run bench:retrieval:corpusvalidates all 6 repositories and all 90 intents against the pinned checkouts.#170 — Matrix execution and artifact merge (c662b4a)
benchmarks/matrix/full.jsondefines the complete matrix as explicit run axes; it expands to 12,960 coordinates across 6 repositories, 3 models, 5 optimization profiles, 4 objectives, all fusion methods, grouped folds, and repository holdouts.benchmarks/retrieval/matrix.tsexpands the manifest deterministically into 30 process invocations and merges artifacts against an explicit plan, rejecting duplicate, missing, and unexpected coordinates. Each merged coordinate keeps the full router result, diagnostics, source timestamp, and timings.artifactSerializationDurationMs, measured from the actual preflight serialization pass.vp run bench:retrieval:matrixexecutes all 30 model-backed runs and writes the merged matrix artifact (release evidence; not part of the dev loop).#173 — Router model and fitting-method comparison (7e4ebd4)
routeWithComparisonModelcompares the production multiplicative router against a bounded regularized log-linear gate over the same parameter space.evaluateRouterComparisonHoldoutscores already-selected candidates on an excluded holdout with no reselection path.#175 — Corpus-size influence (3463d81)
vp run bench:retrieval:corpus-size).(corpus size, fusion, profile, objective, strategy, fold)coordinates and fits a per-channel log-linear model overlog(chunkCount).Validation
vp checkclean (format, lint, types).vp test: 71 files, 498 passed, 1 skipped.vp run lint:fallowat the pre-existing finding baseline (no new dead exports or duplication).vp run bench:retrieval:corpusandbench:retrieval:corpus-sizegreen on the pinned checkouts.