Repository navigation
chore: upgrade Ebitengine to v2.10.4 - #21
Merged
Merged
Conversation
Ebitengine v2.9.9 -> v2.10.4, with the modules it brings along: go-text/typesetting 0.3.5, oto/v3 3.5.0, purego 0.11.0, and golang.org/x/image, x/sys and x/text. v2.10 deprecates audio Player.Close (staticcheck SA1019), so switching music now calls PauseAndStopReading, its named replacement. The player is dropped right after, as before, so music behaves the same. Font fallback's glyph lookup through the face source still reaches the font (TestGlyphLookupReachesTheFont passes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ebitengine v2.9.9 -> v2.10.4, the latest stable release, with the modules it brings along: go-text/typesetting 0.3.5, oto/v3 3.5.0, purego 0.11.0, and golang.org/x/image, x/sys and x/text.
Player.Close(staticcheck SA1019, which would fail CI), so switching music now callsPauseAndStopReading, its named replacement. The player is dropped right after, as before, so music behaves the same.TestGlyphLookupReachesTheFontstill passes, so that path is intact on v2.10.Checked locally: gofmt, go vet, js/wasm vet and build, staticcheck, go test (all green).