feat(server): encode DeepSeek V4 reasoning effort - #630
Conversation
610b970 to
1924d7c
Compare
|
Rebased onto current main (e79f1b6), preserving the merged DeepSeek named-tool-call coverage while resolving the documentation and unit-test conflicts. The rebased commit is 1924d7c. Validation on the gfx1151 ROCm host: dflash_server builds successfully; test_server_unit passes 370/370; test_feature_gate passes 1/1; and the focused reasoning-prefix, tool-capability, and reasoning-capability tests each pass independently. GitHub Actions for the new head are currently awaiting maintainer approval. |
a4a1f20 to
1616e3d
Compare
|
Rebased and requalified against current Final head: Key corrections made during the rebase/review:
Validation is green on the rebased head: full GitHub CI (Windows, hosted Linux/CUDA and C++ server tests, Strix Halo gfx1151, R9700 gfx1201, RTX 3090, and DGX GB10), focused tests against the R9700-built The PR is now conflict-free and ready for merge. It has not been merged. |
1616e3d to
21fddbc
Compare
|
Correction to my earlier ready-for-merge note: a second contract audit found one real blocker in the previous head. Bare Fixed in
The regression tests were run against both versions: they fail on The PR remains one commit directly on current |
21fddbc to
10514b5
Compare
|
Final audit follow-up: head |
|
Final status for
With the renderer-only budget-opt-in regression fixed and covered, I now consider this head ready to merge. It has not been merged. |
Summary
Add the official DeepSeek V4 Flash
low,high, andmaxreasoning-effortencodings to the native renderer.
lowadds no model-facing prefixhighandmaxuse the exact official prompt prefixesreasoning.effort, top-levelreasoning_effort, andchat_template_kwargs.reasoning_effortmediumandxhighto DeepSeek Flashhighx-highextension as a separate budget tier,using the model-facing
maxencodinghighmodel-facing default when thinking is enabled withoutan effort; disabling thinking suppresses all effort prefixes and budgets
chat_template_kwargs.thinkingandenable_thinkingbooleansrenderer-only; only
thinking.type: enabledor an explicit effort opts intothe force-close budget envelope and
finish_details/propsagent-turn-cache canonicalization
Official references:
Rebase
Rebased onto
mainatc994209, including PRs #640 and #647. The serverrendering-helper conflict was resolved by preserving
add_generation_promptand passing the normalized effort through the shared helper.
Validation
controls versus budget-envelope opt-in
precedence, default effort, renderer overrides, and explicit token budgets
low,high,max, thinking-disabled,and no-generation-prompt rerenders
test_server_unit: 423/423 passing on gfx1201git diff --check10514b5: Windows, hostedCUDA/C++ server tests, R9700, Strix Halo, RTX 3090, DGX GB10, workspace, and
speed-profile workflows