feat(pflash): improve AMD defaults and enable rocWMMA - #669
Draft
Graffioh wants to merge 3 commits into
Draft
Conversation
Graffioh
force-pushed
the
codex/pflash-amd-adaptive-ubatch
branch
from
August 27, 2026 06:56
557f148 to
c594b87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.95while preserving user overrides and logging the effective valueOFFand warning on q8 fallbackValidation
Tested on the local Strix Halo
gfx1151GPU pinned withHIP_VISIBLE_DEVICES=1.-DDFLASH27B_P2_USE_ROCWMMA=OFF: fallback remains disabled as requested-j$(nproc)gfx1151git diff --checkpassedA full all-target HIP build reaches the unrelated existing
test_rms_norm_hip.cpp:50compatibility failure (cudaErrorNoDeviceis not defined for this HIP build). The affected targets compile and link successfully.