Enabled scroll-glue to work on the body element.#13
Open
marcells wants to merge 1 commit intoLuegg:masterfrom
Open
Enabled scroll-glue to work on the body element.#13marcells wants to merge 1 commit intoLuegg:masterfrom
marcells wants to merge 1 commit intoLuegg:masterfrom
Conversation
Collaborator
|
Would you be able to rebase this change on the latest master branch, in case it is still valid? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I made scroll-glue work on body elements. In that case you've to register on the
window.onscrollevent. The calculation inshouldActivateAutoScroll()is a bit different to normal elements, too.I tried to create karma tests for the extended behavior, but if I understand it correctly, the compiled templates will be appended below the body element. That would result in two nested body tags, which obviously doesn't work.
Kind regards
Marcell