fix(publish): set CI=true for screenshot capture's pnpm install - #94
Merged
Conversation
pnpm's interactive confirmation before removing a stale node_modules has no TTY to prompt on in this exec.Command, so it aborts with ERR_PNPM_ABORTED_REMOVE_MODULES_DIR_NO_TTY instead. CI=true tells pnpm to auto-confirm, per its own suggested fix. Signed-off-by: Lukas Hirt <info@hirt.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm install --frozen-lockfileinprepareOCISForCapture(internal/marketplace/ocis.go) has no TTY attached, so pnpm's interactive confirmation before removing a stalenode_modulesaborts withERR_PNPM_ABORTED_REMOVE_MODULES_DIR_NO_TTYinstead of prompting.CI=trueon the command's environment tells pnpm to auto-confirm, per pnpm's own suggested fix in the error output. This was previously causing a full retry cycle inextctl publish's screenshot capture (fresh oCIS bring-up + fresh Claude spec) instead of just installing cleanly.Test plan
go build ./...extctl publishagainst an extension whosenode_modulesis stale to confirm install no longer aborts