fix(publish): allow lockfile reconciliation for pinned-capture install - #96
Merged
LukasHirt merged 1 commit intoJul 23, 2026
Merged
Conversation
pinExtensionSourceToRelease moves an extension's package.json back to an old release's dependency versions, but the root pnpm-lock.yaml still reflects the current default branch. For any release but the latest, pnpm install --frozen-lockfile then fails with ERR_PNPM_OUTDATED_LOCKFILE. The node_modules produced here is throwaway, so let pnpm reconcile. Signed-off-by: Lukas Hirt <info@hirt.cz>
LukasHirt
enabled auto-merge (squash)
July 23, 2026 18:15
LukasHirt
deleted the
fix/publish-pinned-capture-install-no-frozen-lockfile
branch
July 23, 2026 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pinExtensionSourceToReleasepins one extension'spackage.jsonback to an old release's dependency versions, but the workspace-rootpnpm-lock.yamlstill reflects the current default branch.cwd, so for any release but the latest,pnpm install --frozen-lockfileinprepareOCISForCapturefails withERR_PNPM_OUTDATED_LOCKFILE— deterministically, not flaky, so the fresh-spec retry loop just burns attempts.--no-frozen-lockfile. Safe because thisnode_modulesis throwaway (never committed, wiped by the nextEnsureCheckouthard reset).Test plan
go build ./...extctl publishagainst an extension with an older, non-latest release and confirm screenshot capture no longer fails onpnpm install.