feat(publish): add approve-all to approve every staged submission at once - #99
Merged
Conversation
…once Approving a batch of staged marketplace submissions one `extctl publish approve <id>` call at a time doesn't scale once more than a couple are pending. `extctl publish approve-all` discovers every local publish/<app-id>-v<version> branch and runs Approve on each, continuing past individual failures and exiting non-zero if any submission failed. Signed-off-by: Lukas Hirt <info@hirt.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extctl publish approve-all, which discovers every locally-stagedpublish/<app-id>-v<version>branch and runs the same push+PR-open flow asextctl publish approve <id>on each — no need to approve staged submissions one at a time.approve-allexits non-zero if any submission failed.listPendingSubmissionshelper ininternal/marketplace/pending.go(andApproveAll) drive it;PendingSubmission/ApproveAllResultare the new exported types.Test plan
go build ./...go vet ./...go test ./...— all packages pass, including newTestListPendingSubmissions/TestListPendingSubmissions_Noneextctl publish approve-all --helpprints as expected