Repository navigation
switch to GPT OSS 20B - #3
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Warning Review limit reached
Next review available in: 84 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (17)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79886e88bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| messages: [{ role: 'user' as const, content: prompt }], | ||
| max_tokens: 50, | ||
| temperature: 0.9 | ||
| max_completion_tokens: 128, |
There was a problem hiding this comment.
When GPT-OSS uses more than 128 completion tokens for its internal reasoning, those tokens consume this same budget even though include_reasoning hides them, so the response can reach finish_reason: length before producing a username. The empty-content check then silently falls back to the non-AI generator, making AI generation unreliable; use a completion budget large enough for both reasoning and the visible answer.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔇 Additional comments (11)
eslint.config.js (1)
1-34: LGTM!package.json (2)
19-19: LGTM!
24-34: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
⚠️ Unverified finding
Sandbox verification was unavailable.Commit the matching lockfile update.
This cohort adds root dev dependencies but does not update a lockfile. Line 27 of
.github/workflows/ci.ymlrunsnpm ci.npm cirequires an existing lockfile that matchespackage.json, or it exits before lint runs. (docs.npmjs.com)Run this check after updating the lockfile:
src/lib/aiUsernameGenerator.ts (1)
1-1: LGTM!src/lib/assets/oneApiCharacterNames.ts (1)
4-4: LGTM!src/lib/usernameVariations.ts (1)
111-111: LGTM!src/routes/+page.svelte (1)
204-204: LGTM!.github/workflows/ci.yml (1)
17-18: 🔒 Security & PrivacyConfirm the workflow before changing checkout credentials.
The repository and
.github/workflows/ci.ymlare unavailable for inspection. Confirm whether later steps require authenticated Git access before addingpersist-credentials: false.src/routes/api/generate-ai/+server.ts (3)
8-8: LGTM!
24-32: LGTM!Also applies to: 127-127
34-36: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
⚠️ Unverified finding
Sandbox verification was unavailable.Make
GROQ_MODELcompatible with the reasoning parameters.
GROQ_MODELis configurable, but Lines 51-54 always sendreasoning_effort: 'low'andinclude_reasoning: false. Groq documentslow,medium, andhighas reasoning settings for GPT-OSS models. A non-GPT-OSS override can therefore be rejected, and the route will use the local fallback instead of the configured model. (console.groq.com)Either restrict
GROQ_MODELto supported GPT-OSS IDs and document that restriction inREADME.mdLine 34, or add these fields only for GPT-OSS models. Add a test for both paths.Proposed fix
const GROQ_MODEL = env.GROQ_MODEL?.trim() || DEFAULT_GROQ_MODEL; +const isGptOssModel = + GROQ_MODEL === 'openai/gpt-oss-20b' || GROQ_MODEL === 'openai/gpt-oss-120b'; const groqRequest = { model: GROQ_MODEL, messages: [{ role: 'user' as const, content: prompt }], max_completion_tokens: 128, temperature: 0.9, - reasoning_effort: 'low' as const, - include_reasoning: false + ...(isGptOssModel + ? { reasoning_effort: 'low' as const, include_reasoning: false } + : {}) };Also applies to: 51-54
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 0e4525c3-be56-4516-b697-2f36da25afd9
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (9)
.github/workflows/ci.ymlREADME.mdeslint.config.jspackage.jsonsrc/lib/aiUsernameGenerator.tssrc/lib/assets/oneApiCharacterNames.tssrc/lib/usernameVariations.tssrc/routes/+page.sveltesrc/routes/api/generate-ai/+server.ts
1 participant
Summary by CodeRabbit
New Features
Bug Fixes
Chores