Implement Youtube Music as Downloader - #47
Merged
Merged
Conversation
Owner
|
Nice work! I think most of this could be implemented under the existing YouTube downloader rather than creating a separate one for YouTube Music, since the only difference seems to be in the search functions. Do you think it would make sense to fall back to the Python API for searching if API_KEY isn’t set? I’ll merge this into dev soon and also clean up the YouTube downloader code a bit. |
Contributor
Author
|
Just dropping in a note here--worked perfectly for my scheduled run this week! Are you suggesting just replacing the YouTube search with the YTMusic one unless an API key is set? I think that could work well if so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements YTMusic as a "downloader"--uses it to search for the right Youtube video, otherwise works the same as the Youtube downloader. Fixes #45
Piggybacks off of the Python library with a basic wrapper script. This complicates the overall setup a bit (we need a Docker image that has Python installed now), but makes it a very simple setup that'll continue to receive updates from the library (as opposed to doing something like compiling a standalone version of the script). The proper, longer-term implementation here is probably setting up something to properly build this, I'm happy to take that as a future enhancement, but this should work fine!
This is my first time working with Go, please give it an extra-critical review.
Tested and works in ad-hoc runs. Will be confirming with this week's playlist that it 100% works (for me at least) and will update here after that.