feat(aws): add AWS Marketplace target to s3-cloud#4
Conversation
This comment has been minimized.
This comment has been minimized.
6c6c1e2 to
51b7a84
Compare
This comment has been minimized.
This comment has been minimized.
51b7a84 to
6bcdfd2
Compare
6bcdfd2 to
9887e48
Compare
This comment has been minimized.
This comment has been minimized.
9887e48 to
fa83621
Compare
This comment has been minimized.
This comment has been minimized.
fa83621 to
11943f6
Compare
This comment has been minimized.
This comment has been minimized.
11943f6 to
b769604
Compare
b769604 to
52b6fa0
Compare
This comment has been minimized.
This comment has been minimized.
52b6fa0 to
4e934f2
Compare
This comment has been minimized.
This comment has been minimized.
4e934f2 to
76cd829
Compare
This comment has been minimized.
This comment has been minimized.
385b752 to
6793e89
Compare
6793e89 to
310bb7f
Compare
This comment has been minimized.
This comment has been minimized.
e6cfc7e to
29bc44c
Compare
29bc44c to
cfea6b0
Compare
This comment has been minimized.
This comment has been minimized.
cfea6b0 to
7c5574f
Compare
This comment has been minimized.
This comment has been minimized.
7c5574f to
bf00144
Compare
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
bf00144 to
ae15e3f
Compare
| AWS_DEFAULT_REGION: us-east-1 | ||
| VPC_ID: ${{ env.VPC_ID }} | ||
| SUBNET_ID: ${{ env.SUBNET_ID }} | ||
| RESCUE_PASSWORD: ${{ github.event.inputs.rescue-password }} |
There was a problem hiding this comment.
The github.event.inputs.rescue-password context is empty for workflow_call triggers, silently dropping the operator-supplied rescue password and making the cleanup-on-failure guard always true, which deregisters a failed AMI even when the operator intended to keep it for debugging. Replace github.event.inputs.rescue-password with inputs.rescue-password on both lines.
RESCUE_PASSWORD: ${{ inputs.rescue-password }}
...
if: failure() && inputs.rescue-password == ''Prompt for LLM
File .github/workflows/packer-ci-aws.yml:
Line 156:
The `github.event.inputs.rescue-password` context is empty for `workflow_call` triggers, silently dropping the operator-supplied rescue password and making the `cleanup-on-failure` guard always true, which deregisters a failed AMI even when the operator intended to keep it for debugging. Replace `github.event.inputs.rescue-password` with `inputs.rescue-password` on both lines.
Suggested Code:
RESCUE_PASSWORD: ${{ inputs.rescue-password }}
...
if: failure() && inputs.rescue-password == ''
Talk to Kody by mentioning @kody
Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.
| AWS_DEFAULT_REGION: us-east-1 | ||
| VPC_ID: ${{ env.VPC_ID }} | ||
| SUBNET_ID: ${{ env.SUBNET_ID }} | ||
| RESCUE_PASSWORD: ${{ github.event.inputs.rescue-password }} |
There was a problem hiding this comment.
The github.event.inputs.rescue-password context is not populated under workflow_call triggers, leaving RESCUE_PASSWORD empty and causing the cleanup-on-failure guard to always deregister the instance even when a rescue password was supplied. Use inputs.rescue-password instead of github.event.inputs.rescue-password on both lines, matching the job's existing use of inputs.cleanup-mode and inputs.pr-number.
RESCUE_PASSWORD: ${{ inputs.rescue-password }}
...
if: failure() && inputs.rescue-password == ''Prompt for LLM
File .github/workflows/packer-ci-aws.yml:
Line 156:
The `github.event.inputs.rescue-password` context is not populated under `workflow_call` triggers, leaving `RESCUE_PASSWORD` empty and causing the `cleanup-on-failure` guard to always deregister the instance even when a rescue password was supplied. Use `inputs.rescue-password` instead of `github.event.inputs.rescue-password` on both lines, matching the job's existing use of `inputs.cleanup-mode` and `inputs.pr-number`.
Suggested Code:
RESCUE_PASSWORD: ${{ inputs.rescue-password }}
...
if: failure() && inputs.rescue-password == ''
Talk to Kody by mentioning @kody
Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.
Summary
Adds a complete AWS Marketplace target for
s3-cloud, mirroring the existing DigitalOcean and Vultr targets.What's included
us-east-1), CloudFormation deployment template, Makefile, submit helper, README, AGENTS.md.packer-ci-aws.yml,packer-release-aws.yml, and dispatch entries inpacker-ci.yml/packer-release.yml.scripts/validate-aws.shthat checks Packer formatting, CloudFormation JSON, shell/Python syntax, and marketplace docs without needing AWS credentials.packer/scripts/install-s3-server.shfrom adocker exec ... rmcommand to the documentedtouch /state/autoupdate.disabledflag-file API.docs/platform-support.mdwith AWS row/feature parity.Verification
Ran
./scripts/validate-aws.shlocally:bash -n✅Out of scope