✨ mini-ltのWeekNavigatorで過去の週に遡れるようにする#241
Open
wwwkah wants to merge 3 commits into
Open
Conversation
- getNavigationWeeks()（今日基準固定）をcurrentWeek基準の相対ナビに変更 - 前後ボタンで任意の過去週に遡れるように - 次回イベント週より未来には進めないよう制限 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Deployed on https://dev-pr-241-birbz3fm6q-an.a.run.app |
Contributor
There was a problem hiding this comment.
Pull request overview
mini-lt の週ナビゲーションを「現在表示中の週」基準に切り替え、過去週を連続してたどれるようにする変更です。mini-lt の公開/管理/投稿画面で使う共通ナビゲータの挙動を更新し、未来方向は次回イベント週までに制限しています。
Changes:
WeekNavigatorの前後リンク生成をcurrentWeek基準に変更- 中央表示を固定のリンクボタンから現在表示週の情報表示に変更
- 次回イベント週より先へ進めないよう、右側ナビゲーションを条件付きで無効化
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const centerDate = formatWeekDate(centerWeek); | ||
| const currentDate = formatWeekDate(currentWeek); | ||
| const nextDate = formatWeekDate(nextWeek); | ||
| const currentLabel = getWeekLabel(currentWeek); |
4 tasks
|
Deployed on https://dev-pr-241-birbz3fm6q-an.a.run.app |
Member
|
過去のものについても表示が "今週" になっているのでここは直した方が良さそう? 
|
Member
|
未来に行けないようになっている部分いいね! |
Member
|
@wwwkah コメントの部分review+対応お願いしたいです 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Closes #206
mini-ltのWeekNavigatorを改修し、過去の週のコンテンツを閲覧できるようにしました。
変更内容
備考
Firestoreエミュレーターの起動に Java 21 以上が必要ですが、現在の環境が Java 17 のため確認できていません。
次回 Java 21 インストール後に動作確認予定です。