Skip to content

ci: プッシュ時にgo fmtを自動実行するワークフローを追加 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wwwkah merged 4 commits into from
Mar 3, 2026
Merged

ci: プッシュ時にgo fmtを自動実行するワークフローを追加 #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0abdb6
ci: add go-fmt workflow and test triggers
wwwkah Feb 19, 2026
59a8011
ci: go fmt on every push, revert verify-openapi trigger
wwwkah Feb 19, 2026
580fdb7
ci: go-fmt check with git diff --exit-code on PR
wwwkah Feb 19, 2026
e3e996f
プッシュ時の対象にメインブランチを追加
wwwkah Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/go-fmt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Go Format
on:
pull_request:
branches:
- main
paths:
- "backend/**/*.go"
Copy link
Copy Markdown
Member

@Shion1305 Shion1305 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainにpushされた時の条件を追加して欲しいかも

Comment on lines +2 to +7
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description states this workflow runs "任意のブランチへのプッシュ時" (on push to any branch), but the actual trigger is "pull_request" targeting only the "main" branch. This is a significant discrepancy. If the intention is to run on push events to any branch, the trigger should be:

on:
  push:
    paths:
      - "backend/**/*.go"

If the intention is to run only on pull requests to main, the PR description should be updated to reflect this.

Copilot uses AI. Check for mistakes.
push:
branches:
- main
paths:
- "backend/**/*.go"

jobs:
go-fmt:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6

- uses: actions/setup-go@v5
with:
go-version-file: backend/go.mod

- name: Run go fmt
working-directory: ./backend
run: |
go fmt ./...
git diff --exit-code
Comment on lines +24 to +28
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description states that if there are differences after running "go fmt", the workflow will "自動コミット＆プッシュ" (automatically commit and push). However, the actual workflow only runs "git diff --exit-code", which will fail the workflow if there are any formatting differences. It does not automatically commit or push any changes.

If the intention is to verify formatting (fail if not formatted), the PR description should be updated. If the intention is to auto-format and commit, additional steps are needed to commit and push the changes back to the branch.

Copilot uses AI. Check for mistakes.
3 changes: 3 additions & 0 deletions .github/workflows/verify-openapi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ on:
pull_request:
branches:
- main
push:
branches:
- main
jobs:
generate:
runs-on: ubuntu-latest
Expand Down