Skip to content

kazuma/change server specification#15

Open
Tsuboi-coder wants to merge 2 commits into
mainfrom
kazuma/change_server_specification
Open

kazuma/change server specification#15
Tsuboi-coder wants to merge 2 commits into
mainfrom
kazuma/change_server_specification

Conversation

@Tsuboi-coder
Copy link
Copy Markdown
Member

  • feat: Integrate OpenAPI-generated API client, refactor profile data model to use English keys, and update social media fields (X/Instagram) across frontend and backend.
  • feat: Make API base URL configurable via environment variable with a localhost fallback.

…odel to use English keys, and update social media fields (X/Instagram) across frontend and backend.
Copy link
Copy Markdown
Member

@Shion1305 Shion1305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、Review遅くなりました 🙏

Comment thread backend/main.go
router := gin.Default()
router.Use(func(c *gin.Context) {
c.Header("Access-Control-Allow-Origin", "http://localhost:3000")
c.Header("Access-Control-Allow-Origin", "*")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この部分を環境変数から変更できる形にして欲しいです 🙏

nickname: string
lastName: string
firstName: string
faculty: string
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DiscordGitHub は消したくないかも

last_name: profile.lastName,
first_name: profile.firstName,
nickname: profile.nickname,
self_introduction: profile.selfIntroduction,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここも同じく!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants