make gen, go fmtの実行#17
Merged
wwwkah merged 3 commits intoMar 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
OpenAPI にメンバー登録(POST /api/members)を追加し、それに伴うフロントの OpenAPI 生成物を更新、さらにメンバー一覧画面をモックから実 API 取得へ切り替えるPRです。
Changes:
- OpenAPI に
/api/membersの POST とMemberCreate/MemberCreateResponseスキーマを追加 - フロント側の OpenAPI Generator 出力(models / docs / api)を更新
MemberListを API から一覧・詳細を取得する実装に変更
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| openapi.yaml | メンバー登録 API とリクエスト/レスポンス schema を追加 |
| frontend/src/lib/api/models/member-create.ts | MemberCreate モデルを追加(生成物) |
| frontend/src/lib/api/models/member-create-accounts.ts | MemberCreateAccounts モデルを追加(生成物) |
| frontend/src/lib/api/models/member-create-response.ts | MemberCreateResponse モデルを追加(生成物) |
| frontend/src/lib/api/models/index.ts | 追加モデルの export を追加 |
| frontend/src/lib/api/docs/MemberCreate.md | MemberCreate ドキュメント追加(生成物) |
| frontend/src/lib/api/docs/MemberCreateAccounts.md | MemberCreateAccounts ドキュメント追加(生成物) |
| frontend/src/lib/api/docs/MemberCreateResponse.md | MemberCreateResponse ドキュメント追加(生成物) |
| frontend/src/lib/api/docs/DefaultApi.md | apiMembersPost の API ドキュメント追加(生成物) |
| frontend/src/lib/api/apis/default-api.ts | apiMembersPost クライアント実装を追加(生成物) |
| frontend/src/lib/api/.openapi-generator/FILES | 生成ファイル一覧に新規ファイルを追加 |
| frontend/components/member-list.tsx | 一覧/詳細を API から取得する実装に変更 |
| backend/pkg/handler/members.go | gofmt による差分(末尾の空行追加) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {member.roles.length > 2 && ( | ||
| {(member.roles ?? []).length > 2 && ( | ||
| <Badge variant="secondary" className="text-xs px-1 py-0"> | ||
| +{member.roles.length - 2} |
There was a problem hiding this comment.
member.roles を (member.roles ?? []) として扱っている一方で、+{member.roles.length - 2} は null/undefined を考慮しておらず、roles が欠落しているレスポンスだと実行時例外になります。同じ null-safe な値(例: 事前に const roles = member.roles ?? [] を作る、または (member.roles ?? []).length を使う)で長さ計算も統一してください。
Suggested change
| +{member.roles.length - 2} | |
| +{(member.roles ?? []).length - 2} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.