Grating compression#364
Conversation
|
LGTM, just a minor docstring error. is this still WIP really? |
|
Yes, in that I haven't tested much, or added tests! |
|
sorry, to clarify--is that still actually in progress, ie are you likely to have time to do it? |
|
Oh, I see! Yes, I plan to do it, when I get time... Tests are not totally trivial, because this includes the full phase, so cannot be directly compared to analytic formulas. So my plan was to manually build an example that I have manually checked and use that as a test basis. |
There was a problem hiding this comment.
Pull request overview
Adds initial support for modeling and optimizing a 4-grating compressor in the Fields module, enabling grating-based spectral-phase propagation and an optimizer for peak-power compression.
Changes:
- Introduces
prop_gratings!/prop_gratingsto apply a grating-compressor spectral phase in the frequency domain. - Adds
optcomp_gratingsto search grating separationLthat maximizes peak power (viaOptim.optimize), returning the optimal separation and compressed field.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I'm happy if you're happy. Please could you add this to #415 when you've merged? |
Adds
prop_gratingsto simply model a grating compressor.