Skip to content

CustomMode changes#409

Draft
SabbahMohammed wants to merge 1 commit into
LupoLab:masterfrom
SabbahMohammed:CustomMode
Draft

CustomMode changes#409
SabbahMohammed wants to merge 1 commit into
LupoLab:masterfrom
SabbahMohammed:CustomMode

Conversation

@SabbahMohammed
Copy link
Copy Markdown

@SabbahMohammed SabbahMohammed commented Feb 6, 2026

This is to be used for data from Kerrianne.

@chrisbrahms
Copy link
Copy Markdown
Collaborator

chrisbrahms commented Feb 6, 2026

Quick comments:

  1. I'd prefer to avoid adding a fairly heavy dependency like XLSX. It would be better for the CustomMode to take the already-loaded arrays, so that you can pass in data from any source. The loading should then be taken care of at the top level (ie in a script)
  2. Isn't CubicSpline doing basically the same thing as what we have in Luna.Maths, either through CSpline or BSpline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SabbahMohammed @chrisbrahms