WIP: Major update to free-space simulations#416
Open
chrisbrahms wants to merge 85 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 29 out of 30 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 33 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
(Nω, Npol, Nr, [Nz]).(Nω, Ny, Nx, [Nz])(i.e. it used the machine vision convention), but this gets confusing when everywhere else it'sxfirst andysecond. Full 3D arrays now have shape(Nω, Npol, Nx, Ny, [Nz]).LinearOpscases for birefringent materials. In these cases, one needs to calculatekxfrom the internal crystal angle, but because the refractive index depends on the incident angle, this gets a bit complicated and needs to be done numerically via momentum conservation.Grid.FreeeGridwhich only has an x-axis and no y-dimension. This is an in-between method of quickly simulating situations with spatial walk-off without needing to go (or before going) full 3D.PhysData, including a newcrystalsset of materials and access to birefringent refractive indices from sellmeier expansions.This branch also includes a dramatic performance enhancement for radially symmetric propagation with envelope fields, which was anomalously slow due to an issue with the matrix multiplication inherent to the QDHT.