Slurm#420
Open
jtravs wants to merge 9 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the SlurmExec execution mode to generate more robust Slurm array-job scripts, adding per-task memory handling, Julia environment selection, thread configuration, and safer path handling, along with expanded user documentation.
Changes:
- Extend
SlurmExecwithmemory,project, andnthreadsoptions and generate SBATCH scripts accordingly. - Add memory parsing to derive Julia
--heap-size-hintfrom Slurm--mem. - Add extensive Slurm usage documentation to the scans guide.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
src/Scans.jl |
Extends SlurmExec, adds heap-hint parsing, and updates Slurm job script generation (mem, threads, quoting, ulimit, Julia binary path). |
docs/src/scans.md |
Documents SlurmExec behavior and provides usage examples and explanation of memory/threads/project handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@copilot check my fixes and resolve addressed threads |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Slurm handling of memory, paths, and julia environments