Repository navigation
Fix IBKR sync timezone handling and protect existing history - #24
Conversation
Signed-off-by: Christopher Downie <Cnicholasdownieyt@gmail.com>
|
Hello Christopher, thank you for the detailed breakdown of the 0.5.1 patch. Following your notes, I performed a complete fresh test: I wiped the database entirely to start from a clean state (brand new SQLite database, clean install of version 0.5.1, and creating a brand new account), but unfortunately, the execution timestamps for IBKR Flex remain completely unchanged regardless of the default import timezone chosen. Since the fix doesn't seem to alter the resulting execution times even on a completely fresh environment, could you please advise what additional troubleshooting steps we should take, or if there is a specific configuration we might be missing to force the timezone offset application? Thank you! |
|
Your original report mentions importing and re-importing a Flex XML file. Could you confirm the exact screen or steps you use to bring that data into the Journal? The fix applies to Import → Broker sync → Interactive Brokers, so I want to make sure we’re investigating the same path. Could you also share the Trade Journal commit or Docker image tag you’re running? Version 0.5.1 is the broker SDK release; the Journal-side update in this PR is also needed to pass the selected timezone through. Thanks. |
Summary
@luxalgo/broker-sdk0.5.1 patch, following Fix IBKR statement timezone conversion (0.5.1) broker-sdk#17. This includes all 22 already-public brokers, including the six integrations added after the journal's previous 0.3.0 dependency.accounts.ibkrSyncTimeZonevia the existing additive database upgrade. Existing rows remain unknown; no timestamps or annotations are rewritten.Related to #16. PR #7's CSV/MT5 behavior remains intact. The confirmed defect is IBKR broker sync; the reporter's "XML import" wording has not been clarified. Direct Flex XML upload remains unsupported, so the issue must remain open pending that clarification; this PR only resolves the proven broker-sync defect.
Verification
connect()→syncAccount()→ temporary SQLite → trade-detail and analytics APIs.08:59:05/10:08:30values persist as12:59:05Z/14:08:30Zand display as14:59:05/16:08:30in Rome.prompt()used to choose a transfer destination, so that browser interaction was not claimed as verified.Recovery behavior
Users with existing IBKR synced executions must back up their full data directory, verify the statement timezone, connect a separate journal account and compare the source report. The original account remains available for notes and comparison. Fresh accounts and repeated syncs under the recorded timezone continue normally.