Repository navigation
Fix contract ROI and replay on local networks - #39
Merged
Merged
Conversation
on101094
added a commit
to on101094/trade-journal
that referenced
this pull request
Oct 9, 2026
Upstream LuxAlgo#39 fixed the same Net ROI bug with netReturnOnEntry (more guards and tests). Resolve the conflicts to upstream's helper and drop this branch's duplicate netReturnOnNotional and its test, keeping only the CHANGELOG entry, which upstream's fix did not add. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects Net ROI for contract-priced trades so the trades list and detail page use the same multiplier-aware calculation. Also fixes candle replay over plain HTTP local networks by removing its dependency on crypto.randomUUID.
Fixes #34
Fixes #33