Repository navigation
Give the bank keys and the rail keys the same housing lamp - #116
Merged
Merged
Conversation
The keys got light instead of an outline; the bank positions and the navigation rail still had the outline. Two of the three surfaces you click responding one way and the third responding another is worse than either choice on its own. Bank keys get a tighter, dimmer version of the same fixture - they sit 2 DIP apart, and a button-sized bloom on each would wash across its neighbours. It deliberately does not light the SELECTED position: the teal pip says which one is engaged and the warm lamp says which one you are on, and running both off the same key would collapse two different questions into one glow. The rail keys draw themselves in code rather than from a template, so the lamp is built there and composed over whatever shadow the active state already chose. An active key keeps its teal halo and gains the warm one, the way a lit key still lights its own seam. D-080 (4) put the rail in scope for exactly this reason: it is the most-clicked surface in the app and it should not be the one thing that stops responding. Not doing here: the rail keys still do not DEFORM. That needs RailStripKey to grow a layered template, which is a bigger change than this one, and the light is the part that makes the console feel like one object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to #114. The keys got light instead of an outline; the bank positions and the navigation rail still had the outline, and two of the three surfaces you click responding one way while the third responds another is worse than either choice alone.
Bank keys get a tighter, dimmer version of the same fixture - they sit 2 DIP apart, and a button-sized bloom on each would wash across its neighbours. It deliberately does not light the selected position: the teal pip says which one is engaged, the warm lamp says which one you are on, and running both off the same key would collapse two different questions into one glow. Pinned by test.
Rail keys draw themselves in code rather than from a template, so the lamp is built there and composed over whatever shadow the active state already chose. An active key keeps its teal halo and gains the warm one. D-080 (4) put the rail in scope for exactly this reason - it is the most-clicked surface in the app.
Not done here: the rail keys still do not deform. That needs
RailStripKeyto grow a layered template, which is a bigger change than this one; the light is the part that makes the console read as a single object. Recorded rather than quietly skipped.194 tests green, including three new guards: no outline on hover for either surface, and the bank lamp never answers the question the pip already answers. Rendered the Rip page hovering a bank position in both themes.