Harden Linux packaging workflow against transient electron-builder network failures - #47
Merged
Merged
Conversation
Co-authored-by: M-Nikox <101933576+M-Nikox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job Package Linux artifacts
Harden Linux packaging workflow against transient electron-builder network failures
Aug 12, 2026
M-Nikox
approved these changes
Aug 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the GitHub Actions Linux packaging jobs by adding a bounded retry loop around npm run make, reducing intermittent CI failures caused by transient electron-builder network/download issues.
Changes:
- Wrap
npm run makein a 3-attempt retry loop with a 15s backoff inpackage-pr-linux. - Apply the same retry loop to the release
package-linuxjob.
Suppressed comments (1)
.github/workflows/ci.yml:164
- Same retry block is duplicated in both Linux packaging jobs. If you keep it inline, it’s still worth parameterizing attempt count/backoff (and avoiding
exit 0inside the loop) so future tuning doesn’t require editing multiple places and later commands won’t be skipped inadvertently.
for attempt in 1 2 3; do
if npm run make; then
exit 0
fi
if [ "$attempt" -lt 3 ]; then
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+69
to
+79
| for attempt in 1 2 3; do | ||
| if npm run make; then | ||
| exit 0 | ||
| fi | ||
| if [ "$attempt" -lt 3 ]; then | ||
| echo "Packaging attempt $attempt failed; retrying after 15s..." | ||
| sleep 15 | ||
| fi | ||
| done | ||
| echo "Packaging failed after 3 attempts." | ||
| exit 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
Package Linux artifactscould fail intermittently duringnpm run makeeven when build inputs were valid. Expected behavior was successful artifact packaging; actual behavior was job failure on transient network errors (e.g.socket hang up).Root cause
electron-builderperforms network-dependent download/rebuild steps during packaging. The Linux packaging jobs treated any first-attempt network interruption as terminal, so transient transport failures failed the workflow.Fix
package-pr-linuxpackage-linuxnpm run makeexecution with a bounded retry loop (3 attempts, 15s backoff).Steps to reproduce (before fix)
electron-builderpackaging.socket hang upand no retry.Screenshots
N/A
Checklist